Merged
Conversation
d81228d to
ff98974
Compare
Collaborator
Author
|
I don't see us needing this in the future right? Maybe I can close it |
Member
|
I think it would still be interesting to have it. What is missing currently? I may be able to take care of it if you don't have time to spend on it |
Collaborator
Author
|
Rebase it. I think if the CI is good it's probably good to go. I ran symbotic for the paper with this using the testcomp runner |
Member
|
Oh, OK! Great, thanks for rebasing! Can you confirm that |
Collaborator
Author
It works on my machine (famous last words 😅) |
Member
|
Hahaha, great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbiotic stuff if you want to add it