Skip to content

Changes to make SciMLSensitivity work #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025
Merged

Changes to make SciMLSensitivity work #122

merged 4 commits into from
Jul 18, 2025

Conversation

albangossard
Copy link
Member

As part of the changes required to make both Enzyme and SciMLSensitivity work with our code (ODINN-SciML/ODINN.jl#350 and ODINN-SciML/Huginn.jl#94), I added θ as an explicit argument in all the functions involved in the SIA. This PR reflects this change.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (772eeae) to head (50f1cdf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/simulations/results/results_utils.jl 0.00% 5 Missing ⚠️
src/glaciers/data/SurfaceVelocityData_utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          22       22           
  Lines        1180     1180           
=======================================
  Hits          864      864           
  Misses        316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albangossard albangossard merged commit 38fcd60 into main Jul 18, 2025
5 checks passed
@albangossard albangossard deleted the enzymeFix branch July 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants