added logic to allow query options in select=* calls #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd requests to http://localhost:64771/v1/Customers?$select=FavoriteAddresses($count=true) and http://localhost:64771/v1/Customers?$select=FavoriteAddresses($count=true),*
wachugamaina
reviewed
Mar 8, 2024
| @@ -443,6 +443,22 @@ await WriteDynamicComplexPropertyAsync(dynamicTypeProperties[property], property | |||
| ResourceContext resourceContext = new ResourceContext(writeContext, structuredType, graph); | |||
|
|
|||
| SelectExpandNode selectExpandNode = CreateSelectExpandNode(resourceContext); | |||
| /*if (expectedType.Definition.FullTypeName() == "ODataRoutingSample.Models.Customer") | |||
There was a problem hiding this comment.
Please delete unused code, you can always retrieve it from Git.
| { | ||
| //// TODO this doesn't handle cases like $select=*,path/to/definedpropery | ||
| //// TODO the defined property gets added twice, but it shouldn't be; webapi could differentiate these cases by looking for '$', but really ODL should have "subsumed" items, and "non-subsumed" items to differentaite bewten the cases | ||
| foreach (var subsumedSelectItem in wildcardSelectItem.SubsumedSelectItems.Cast<PathSelectItem>().Where(item => item.HasOptions)) |
There was a problem hiding this comment.
var subsumedSelectItems = wildcardSelectItem.SubsumedSelectItems.Cast().Where(item => item.HasOptions);
foreach (var subsumedSelectItem in subsumedSelectItems)
| @@ -517,6 +521,21 @@ internal Expression ProjectElement(QueryBinderContext context, Expression source | |||
| continue; | |||
| } | |||
|
|
|||
| var wildcardSelectItem = selectItem as WildcardSelectItem; | |||
| if (wildcardSelectItem != null) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.