Skip to content

Set the default of MaxTop to null #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

droyad
Copy link

@droyad droyad commented Apr 20, 2018

Issues

n/a

Description

With the default MaxTop set to 0, any query that contains $top will fail. It's not very obvious how to set this default. The value supplied by ODataValidationSettings is ignored when as well.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

@AlanWong-MS AlanWong-MS self-requested a review June 27, 2018 21:46
@AlanWong-MS AlanWong-MS self-assigned this Jun 27, 2018
@AlanWong-MS
Copy link
Contributor

@droyad, there appear to be four failures in the WebApiOData.E2E.AspNet test suite based on our buddy build:

2018-07-02T22:31:11.4729679Z Failed   Microsoft.Test.E2E.AspNet.OData.ModelBoundQuerySettings.CombinedTest.CombinedTest.QuerySettingsOnPropertyNegative(entitySetUrl: "{0}/enablequery/Orders", url: "?$expand=Customers2($expand=Order($top=3))", error: "top")
2018-07-02T22:31:11.4729679Z Failed   Microsoft.Test.E2E.AspNet.OData.ModelBoundQuerySettings.CombinedTest.CombinedTest.QuerySettingsOnPropertyNegative(entitySetUrl: "{0}/modelboundapi/Orders", url: "?$expand=Customers2($expand=Order($top=3))", error: "top")
2018-07-02T22:31:12.1135961Z Failed   Microsoft.Test.E2E.AspNet.OData.ModelBoundQuerySettings.CombinedTest.CombinedTest.DefaultQuerySettings(url: "{0}/enablequery/Orders?$top=3", error: "top")
2018-07-02T22:31:12.1135961Z Failed   Microsoft.Test.E2E.AspNet.OData.ModelBoundQuerySettings.CombinedTest.CombinedTest.DefaultQuerySettings(url: "{0}/modelboundapi/Orders?$top=4", error: "top")

Can you please address those test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants