Skip to content

Added CustomerPaymentMethods #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Added CustomerPaymentMethods #158

merged 2 commits into from
Mar 25, 2019

Conversation

tobias-kuendig
Copy link
Member

@tobias-kuendig tobias-kuendig commented Mar 7, 2019

Corresponding theme changes:

OFFLINE-GmbH/oc-mall-theme@509d2b2

Fixed #154

@artistro08
Copy link

I wasn't able to test this. Couldn't get it to work in my environment. Is it ready to be merged?

@tobias-kuendig tobias-kuendig merged commit bcb8b77 into develop Mar 25, 2019
@tobias-kuendig
Copy link
Member Author

I'm releasing this as an edge update. It would be great to have someone test the new feature using October's edge update channel.

@tobias-kuendig tobias-kuendig deleted the stripe-customers branch March 25, 2019 11:57
@artistro08
Copy link

artistro08 commented Mar 25, 2019 via email

@artistro08
Copy link

artistro08 commented Mar 25, 2019

So it worked! It did create a customer in the stripe dashboard. Now, the only thing that I think is missing is sending the billing address and shipping address with the email and we should be set! I tested this on my local workstation with the Mall Theme. Worked really well.

I also tested this with my own theme. It saves the card information as expected if they are logged in

@tobias-kuendig
Copy link
Member Author

Thank you very much for testing. I'll try to add the addresses as well. The omnipay docs are a bit sparse on that.

@artistro08
Copy link

No worries.

@tobias-kuendig
Copy link
Member Author

Omnipay currently does not support the shipping data to be sent to Stripe.

I've created a PR that adds this feature. If it gets merged we will have support for it as soon as a new Omnipay version is released. The current version of the mall plugin is already providing all needed information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants