[uk]Added fan intents to Ukrainian language #158
Conversation
| @@ -2,7 +2,7 @@ language: uk | |||
| areas: | |||
| - name: Кухн(я|і) | |||
| id: kitchen | |||
| - name: Гостинн(а|ій) | |||
| - name: Вітальн(я|і) | |||
There was a problem hiding this comment.
Names should not use matching syntax. They should be as you would name them in Home Assistant.
There was a problem hiding this comment.
Why would you want to match on both?
There was a problem hiding this comment.
It is hard to explain in English, I’m not a linguist.
Basically in all Slavic languages we change the ending of nouns and adjectives depending on Cases. As you can see in pl situation is the same https://github.com/home-assistant/intents/blob/main/tests/pl/_fixtures.yaml
For example:
I want to name the kitchen area - it is ‘Кухня’
But if I want to reference something, like ‘Light at the kitchen’ - it is ‘Light на Кухні’
or:
Lamp - Лампа
Turn on Lamp - Ввімкни Лампу
We change the last 1-2 letters in such cases or add vowels if the word ends with consonants.
I added it as is for now to not fail tests but there should be more complex solution.
There was a problem hiding this comment.
Your name in Home Assistant is static. It does not contain sentence syntax. It should never have been allowed here. This needs to be solved differently.
There was a problem hiding this comment.
Hungarian similar:
Kitchen - Konyha
Light in the kitchen - Lámpa a konyhában
Turn on the light in the kitchen - Kapcsold fel a lámpát a konyhában
There was a problem hiding this comment.
And they also depend on other factors...
There was a problem hiding this comment.
Check. Let's track it in #164. For now we're going to approve this PR as it's not new for UK.
* add-lights-intents-fr * some update * Add somes intents for fr * Add somes intents for fr * Add somes intents for fr * Alighe with main * Fix typo errors * Fix some PR comments * add-lights-intents-fr * some update * Add somes intents for fr * Add somes intents for fr * Alighe with main * Fix typo errors * Update CONTRIBUTING.md * First Portugese translations (#162) * First translations * Corrected some typos and files * Corrected the code * Errors Only (#156) * [ES] commons yaml fixes in spanish (#159) * commons in spanish and catalan * Revert catalan changes * Revert catalan changes * new skip_word * [CA] Initial Catalan language support (#111) * initial Catalan intents * Adding some initial sentences and tests for CA * Remove redundant quotes * Add missing sentences and tests * Update expansion_rules and sentences/tests * Fix conflict "close curtains" with "turn off" Light can be "closed" as in "turn off" * Update fan test * Add response for temperature * Fix test Co-authored-by: jorclaret <[email protected]> Co-authored-by: Paulus Schoutsen <[email protected]> * Validate area ids correct (#165) * Validate that all area IDs used in fixtures are correct * Fix Polish area name * [uk]Added fan intents (#158) * Validate to guard no question marks added to sentences (#166) * Spelling updates * [SR] Light sentences (#168) * Errors Only * Lights * Finished light sentences and tests * [PT] Added Portuguese sentences (#169) * started adding portuguese common words and some sentences * sentences for closing covers * finished the remaining sentences; slightly improved zone expansion rules; * modified responses; started modifying tests; * fixed indentation problems * fixed indentation problems * fixed slot usage; fixed color mapping by using in-out; * fixed mis-use of slots; added one more skipped word; * added more tests for temperature getting and setting * added tests for opening and closing covers * made tests for fans; made tests for generic on off; fixed fan sentences; added one more slot combination to allow for name+area slots; * added tests for setting light and corrected sentences definitions * added tests for lights on and off * added missing tests on light set; added female variant of supported colors; * Fix some PR comments * Fix rebase * Fix rebase * Add new line at end of some files * Add new line at end of some files * Fix tests errors * Rewrite all sentences for more clarity * Rewrite all sentences for more clarity * Some fix after CR * Fix CI lint issue * Update for fix failling test * Little clean * Fix tests * Move test sentences to correct files and de-duplciate Co-authored-by: root <[email protected]> Co-authored-by: Paulus Schoutsen <[email protected]> Co-authored-by: hugovsky <[email protected]> Co-authored-by: cvladan <[email protected]> Co-authored-by: Rafael Piñero Jiménez <[email protected]> Co-authored-by: David Girón <[email protected]> Co-authored-by: jorclaret <[email protected]> Co-authored-by: Oleksandr Kapshuk <[email protected]> Co-authored-by: Alexandre Vieira <[email protected]>
No description provided.