-
Notifications
You must be signed in to change notification settings - Fork 626
[IT] Add support for HassSetPosition #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Looks good, thanks! |
|
It's marked as draft: are you still working on this? |
Oh, it wasn't intentional.
Well, in fact I'm just updating some sentences to use min/max position. |
- updated sentences with expansion rules - added support for min/med/max position (list and sentences) - minor fixes
- minor fixes to expansion rules and blank spaces
|
This PR is showing issues that are caught by |
|
@auanasgheps @Sartoric I fixed the file formatting, it should be good to go now. When looking at the intent dashboard, I noticed that Italian only needs |
|
I have created a template generator to get LLMs to help with intent coverage in #2528. It created these files to kickstart Italian coverage of |
|
Thanks @balloob, I'll look into your suggestion and verify it! |
|
@auanasgheps |
|
I'm trying to add the HassListAddItem It should be a correct case, so I'm probably missing something stupid here :) |
|
It was indeed a stupid thing :) |
|
Approving this one too. Thanks for your work. |
Add support for cover position for the Italian language