[DE] HassLightSet: color control by floor and satellite area #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add color by floor and color by satellite area controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third step in a bigger change process for HassLightSet. ( see PR #3294 )
This PR optimizes color controls by area.
Color controls by floor and by corresponding satellite area are also introduced in this PR.
This PR also removes previously allowed but not working slot combinations - so hopefully no more "Es ist ein Fehler aufgetreten".
I decided to implement sentences with
<alle_lichter>only together with either<hier>or<area_floor>since without one of those two the behavior of hassLightSet would not be consistent with Light turnOn/Off where<alle_lichter>without any further context turns on or off all lights everywhere.overall sentence count compared to step 2 ( #3315 ) ~ + 6 million. while this is quite a lot there is a lot of new functionality introduced with this PR as well and #3314 reduced OSC quite a lot 😉
If you find potential to further reduce sentence count within this PR I´m happy to adjust!
changes to the commons file are covered by #3314 and will be removed/unnecessary once that PR is merged.
changes to light_HassLightSet in lines 25/26, 32-35 and 53-58 are covered by previous PRs (#3314 #3315 ) and will be removed or unnecessary as well once the previous PRs are merged.