Skip to content

Conversation

staticdev
Copy link
Contributor

@staticdev staticdev commented Sep 23, 2025

Summary:

  • Adds a new argument --error-on-warn-pr to script/intentfest/validate.py that converts warns into errors for newly changed files with validation errors.
  • Adds a separate job on the ci workflow to do complete validation with warnings if no language has been changed, or with errors for files in language changed (PR only).
  • Removes the script/intentfest/validate.py to remove redundant execution.

This PR was tested with an extra commit on top here to force it to fail with the correct errors.

@staticdev staticdev force-pushed the ci/intentfest-validate-error branch from eb8e179 to 5b34bea Compare September 23, 2025 16:29
@staticdev staticdev marked this pull request as draft September 23, 2025 16:34
@staticdev staticdev force-pushed the ci/intentfest-validate-error branch 9 times, most recently from 35c4d50 to 9ab26a6 Compare September 25, 2025 11:13
@staticdev staticdev marked this pull request as ready for review September 25, 2025 11:30
@staticdev staticdev requested review from balloob and synesthesiam and removed request for synesthesiam September 25, 2025 11:30
@staticdev staticdev force-pushed the ci/intentfest-validate-error branch from 9ab26a6 to 96295a7 Compare September 29, 2025 11:32
@synesthesiam synesthesiam self-assigned this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants