Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user store #4437

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add user store #4437

wants to merge 2 commits into from

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Oct 25, 2024

Context

  • Add user store to avoid having to authenticate on every page reload

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 1f1b2f8
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6722b8cdf291bf0008064805
😎 Deploy Preview https://deploy-preview-4437--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 1f1b2f8
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6722b8cd82825f0008f12fea
😎 Deploy Preview https://deploy-preview-4437--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Oct 25, 2024

Viewers    Run #4388

Run Properties:  status check failed Failed #4388  •  git commit 1f1b2f8981: Merge branch 'master' into feat/user-store
Project Viewers
Branch Review feat/user-store
Run status status check failed Failed #4388
Run duration 04m 24s
Commit git commit 1f1b2f8981: Merge branch 'master' into feat/user-store
Committer Igor Octaviano
View all properties for this run ↗︎

Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 20
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎

Tests for review

Failed  customization/HangingProtocol.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should display 3 up Test Replay Screenshots Video
Failed  measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed Test Replay Screenshots Video
Failed  volume/MPR.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF MPR > should not go MPR for non reconstructible displaySets Test Replay Screenshots Video
Failed  customization/OHIFDoubleClick.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Double Click > Should double click each viewport to one up and back Test Replay Screenshots Video
Failed  measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed Test Replay Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant