tests: add coverage for new delete-when-done value in configuration #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2025
oferda4
force-pushed
the
feat/pcap-delete-no-alerts
branch
from
357ac4e to
6d6456c
Compare
5 tasks
5 tasks
jufajardini
reviewed
Oct 29, 2025
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Something to help this only fail for main :)
Comment on lines
+1
to
+2
| command: | | ||
| ${SRCDIR}/src/suricata -c ${SRCDIR}/suricata.yaml -S ${TEST_DIR}/test.rules -r ${TEST_DIR}/input.pcap -l ${OUTPUT_DIR} --set pcap-file.delete-when-done=non-alerts --set classification-file="${SRCDIR}/etc/classification.config" --set reference-config-file="${SRCDIR}/etc/reference.config" |
Contributor
There was a problem hiding this comment.
Add min-version requirement here and others where missing, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7786?next_issue_id=7785
Previous PR: #2656
Changes:
Suricata PR: OISF/suricata#14151