Skip to content

Conversation

@jufajardini
Copy link
Contributor

In investigating whether would backport an exception policy for stream-async to main 7.0.x.

Wondering if we should have tests with different pcaps. While I settled here for picking a single pcap and splitting the traffic to create an async scenario, resulting in the tests seen here, with no alerts or app proto seen in stream-async-6063-cli-02, some other cases (using async pcaps present in our tests, already) showed scenarios where Suri was able to generate alerts and other events against async traffic, even with stream.async-oneside=false

I added the flow events to the tests in case those would show any difference with async true or false, but didn't notice anything.

Related to
Task #6063

Ticket

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6063

@victorjulien
Copy link
Member

I think this is a great start. In general the async logic is under cooked, and it's unclear how the various protocols and features work with async. I wonder if we should just have a stream-async subdir and then have per protocol tests.

It would probably also be a good goal to then document the per protocol behavior/support in https://docs.suricata.io/en/latest/protocols/protocols.html

@jufajardini
Copy link
Contributor Author

I think this is a great start. In general the async logic is under cooked, and it's unclear how the various protocols and features work with async. I wonder if we should just have a stream-async subdir and then have per protocol tests.

It would probably also be a good goal to then document the per protocol behavior/support in https://docs.suricata.io/en/latest/protocols/protocols.html

Agreeing to both things

I think this is a great start. In general the async logic is under cooked, and it's unclear how the various protocols and features work with async. I wonder if we should just have a stream-async subdir and then have per protocol tests.

It would probably also be a good goal to then document the per protocol behavior/support in https://docs.suricata.io/en/latest/protocols/protocols.html

Added: https://redmine.openinfosecfoundation.org/issues/8011

@jufajardini
Copy link
Contributor Author

Added tests that show the difference with stream.async-oneside=false to compare with tests

  • alert-testmyids-async
  • bug-2491-02
    Moved all tests to stream-async/http since all of them are for http, so far.

@jufajardini jufajardini force-pushed the sv-6063-tests/v1 branch 2 times, most recently from 2c101f9 to 35a76f5 Compare October 22, 2025 18:41
Related to
Task #6063
Task #8011
As part of the investigation for Suricata's behavior for stream-async.

Related to
Task #6063
Task #8011
@victorjulien
Copy link
Member

Great stuff.

@catenacyber
Copy link
Collaborator

Is this still a draft ?

Should it be labelled tests pass ?

@victorjulien
Copy link
Member

Would be great to get this part already going in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants