tests: add test for force-hash YAML validation. #2735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| checks: | ||
| - shell: | ||
| args: | | ||
| (grep -q "Invalid configuration: force-hash algorithm 'shanani' must be one of: md5, sha1, sha256" suricata.log || \ |
Member
There was a problem hiding this comment.
which one is expected to succeed? Why are there 2 checks?
Member
There was a problem hiding this comment.
Hi! This does not seem to be resolved/answered. Could you please address this?
catenacyber
reviewed
Nov 4, 2025
Add test to ensure Suricata rejects invalid force-hash algorithm values in file logging configuration. The test verifies that an invalid hash type (e.g., 'shanani') causes Suricata to exit with an error during configuration validation. Issue: OISF#4330
kaddujames501-ship-it
force-pushed
the
sv-Force-Hash
branch
from
493925e to
24bf792
Compare
Author
|
hello @catenacyber , @inashivb changes are ready |
catenacyber
reviewed
Nov 5, 2025
3 tasks
Collaborator
|
New version in #2751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to ensure Suricata rejects invalid force-hash algorithm values in file logging configuration. The test verifies that an invalid hash type (e.g., 'shanani') causes Suricata to exit with an error during configuration validation.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status: OISF/suricata#14223
Redmine ticket: OISF#4330