Detect prefilter events 6291 v1.1 #11337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused preprocessor value; exposed by compilation warning
Ticket: 7106
Ticket: 6291
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11337 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 935 935
Lines 247310 247311 +1
=======================================
+ Hits 203833 203845 +12
+ Misses 43477 43466 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPW2_autofp_suri_time. Pipeline 21153 |
victorjulien
approved these changes
Jun 20, 2024
Merged
|
Merged in #11353, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/6291
https://redmine.openinfosecfoundation.org/issues/7106
Describe changes:
Tested with a random
TLPW1-ca1fb1ad30189110cc225620dc537368.pcapwith 487089 packets,time ./src/suricata -c suricata.yaml -k none -r TLPW1-ca1fb1ad30189110cc225620dc537368.pcap -S rules/decoder-events.rules --runmode=singlegoes down from 12/14 seconds to 8#11328 first commits that are not draft