Ssh add first frames 5734 v1 #11340
Closed
Ssh add first frames 5734 v1 #11340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5734
for SSH packets that mark the end of plaintext
catenacyber
commented
Jun 21, 2024
| flow, | ||
| stream_slice, | ||
| input, | ||
| (head.pkt_len + 4) as i64, |
There was a problem hiding this comment.
Is this right Victor ?
Setting the frame length that gets over the available data so far...
There was a problem hiding this comment.
if final length is unknown, it should set -1 and update the frame's len when the final length is available
There was a problem hiding this comment.
Final length is known but we do not have the full data yet. You just told me it is ok
|
Information: QA ran without warnings. Pipeline 21159 |
|
Information: QA ran without warnings. Pipeline 21174 |
Closed
|
Clean in #11372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5734
Describe changes:
SV_BRANCH=OISF/suricata-verify#1932