Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/536/20240717/v4 #11515

Merged
merged 11 commits into from
Jul 18, 2024
Merged

Next/536/20240717/v4 #11515

merged 11 commits into from
Jul 18, 2024

Conversation

victorjulien
Copy link
Member

mmaatuq and others added 11 commits July 17, 2024 06:13
@mmaatuq @victorjulien
imap: extend detection patterns
64d18e3 
Ticket: OISF#2886

Signed-off-by: mmaatuq <[email protected]>
@catenacyber @victorjulien
smtp: adds server side detection
cc3dde8 
Ticket: OISF#1125
@catenacyber @victorjulien
ftp: adds server side detection
694b279
@catenacyber @victorjulien
smtp: recognize more reply codes
e2d1d05 
Ticket: 6821
@catenacyber @victorjulien
smtp: do not return error on NULL buffer for end of stream
eac9cd9
@catenacyber @victorjulien
smtp: add port 465 for probing
b8c1209
@glongo @victorjulien
rust/ldap: implement types and filters
ce7e190 
This implementation adds types and filters specified in the LDAP RFC to
work with the ldap_parser.
Although using the parser directly would be
best, strange behavior has been observed during transaction logging.
It appears that C pointers are being overwritten, leading to incorrect
output when LDAP fields are logged.
@glongo @victorjulien
rust/ldap: implement app-layer
93da339
@glongo @victorjulien
rust/ldap: implement logger
910a5b2
@glongo @victorjulien
doc: add ldap protocol
70ed9f9
@victorjulien
rust/ldap: add ldap-parser to Cargo.lock.in
6598a69
@victorjulien victorjulien added the needs baseline update QA will need a new base line label Jul 17, 2024
@github-actions GitHub Actions
Copy link

NOTE: This PR may contain new authors.

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.48077% with 307 lines in your changes missing coverage. Please review.

Project coverage is 82.54%. Comparing base (bce8f4b) to head (6598a69).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11515      +/-   ##
==========================================
- Coverage   82.66%   82.54%   -0.12%     
==========================================
  Files         918      923       +5     
  Lines      247447   248460    +1013     
==========================================
+ Hits       204543   205083     +540     
- Misses      42904    43377     +473
Flag Coverage Δ
fuzzcorpus 60.52% <19.10%> (-0.43%) ⬇️
livemode 18.64% <7.69%> (-0.08%) ⬇️
pcap 43.99% <67.64%> (+0.17%) ⬆️
suricata-verify 61.72% <68.90%> (+0.08%) ⬆️
unittests 59.11% <10.57%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW2_autofp_stats_chk
.flow.end.tcp_state.syn_recv 0 1 -
SURI_TLPW1_stats_chk
.app_layer.flow.imap 0 402 -
.app_layer.flow.failed_tcp 10174 8676 85.28%
.app_layer.error.smtp.parser 409 42 10.27%
SURI_TLPR1_stats_chk
.app_layer.flow.smtp 335817 347642 103.52%
.app_layer.flow.imap 0 231 -
.app_layer.flow.failed_tcp 178240 165687 92.96%
.app_layer.tx.ftp 101030 95392 94.42%
.app_layer.error.smtp.parser 527 144 27.32%
.ftp.memuse 10637 2916 27.41%

Pipeline 21584

@victorjulien victorjulien merged commit 6598a69 into OISF:master Jul 18, 2024
58 checks passed
This was referenced Jul 18, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukashino lukashino lukashino approved these changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees
No one assigned
Labels
needs baseline update QA will need a new base line
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@victorjulien @suricata-qa @lukashino @mmaatuq @catenacyber @glongo