Applayer plugin 5053 final v3.6 #11987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of a global variable. For easier initialization with dynamic number of protocols
for expectation_proto Ticket: 5053
for alproto_names Ticket: 5053
Ticket: 5053
so that we can use safely EXCEPTION_POLICY_MAX*sizeof(x)
Ticket: 5053 delay after initialization so that StringToAppProto works
Ticket: 5053 The names are nwo dynamic
Ticket: 5053
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| AppProto alproto, int direction, int to_client_progress, int to_server_progress) | ||
| { | ||
| size_t i = 0; | ||
| while (al_protocols[i].al_proto != ALPROTO_UNKNOWN && i < ALPROTO_WITHFILES_MAX) { |
Check failure
Code scanning / CodeQL
Array offset used before range check High
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11987 +/- ##
==========================================
+ Coverage 82.77% 82.90% +0.12%
==========================================
Files 910 910
Lines 249016 258292 +9276
==========================================
+ Hits 206134 214126 +7992
- Misses 42882 44166 +1284
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23133 |
|
Needs rebase to take care of #11983 |
|
Rebased in #12052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
#11572 final round + #11910 with more
Example plugin at https://github.com/catenacyber/suricata-zabbix