Smb hashmap/v6 #12028
Smb hashmap/v6 #12028
Conversation
Don't tag the session as gap'd when the GAP is in a precise location: 1. in "skip" data, where the GAP just fits the skip data 2. in file data, where we pass the GAP on to the file This reduces load of GAP post-processing that is unnecessary in these case.
Ticket: OISF#5672.
Use `lru` crate. Add `app-layer.protocols.smb.max-guid-cache-size` to control the max size of the LRU cache.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12028 +/- ##
=======================================
Coverage 83.24% 83.25%
=======================================
Files 910 910
Lines 258136 258165 +29
=======================================
+ Hits 214895 214928 +33
+ Misses 43241 43237 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23175 |
| SCLogError!("Invalid max-dcerpc-frag-cache-size value"); | ||
| } | ||
| } | ||
| let retval = conf_get("app-layer.protocols.smb.max-ssn2vec-cache-size"); |
There was a problem hiding this comment.
this is a bit of a multi purpose store for mapping ssn id to various things, hard to come up with a good name
There was a problem hiding this comment.
Also seems a bit of a low level tuneable. I wonder if such items should be left out of our default configuration file and well documented in an SMB chapter of the user guide.
There was a problem hiding this comment.
yeah probably, but still need a reasonable name :)
|
replaced by #12036 |
3 participants
#11786 with all hashmaps turned to lru