-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform rust 7229 v8 #12065
Closed
Closed
Transform rust 7229 v8 #12065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7229
Ticket: 7229
Ticket: 7229
md5, sha1 and sha256 Ticket: 7229
Ticket: 7229
Ticket: 7229
Ticket: 7229
Ticket: 7229
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12065 +/- ##
==========================================
- Coverage 83.42% 83.41% -0.02%
==========================================
Files 910 906 -4
Lines 257642 257689 +47
==========================================
- Hits 214949 214941 -8
- Misses 42693 42748 +55
Flags with carried forward coverage won't be shown. Click here to find out more. |
Next in #12068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7229
Describe changes:
#12061 with more transforms moved
Only base64 and pcrexform left in C
Benchmark
./src/suricata -r bigf.pcapng -S bigf.rules -c bigf.yaml -k none -l log --runmode single
with big.rules being
alert tcp any any -> any any (file.data; strip_whitespace; content:"hasxspace"; sid:1;)
and bigf.pcapng being a capture of http1 download of 28 Mbyte file SV datasets-1m-StringSets/datasets.csv and bigf.yaml having all kinds of options for profilingwith PR
With master
So 77389980 vs 81533120 does not seem significant for a difference