Skip to content

Conversation

RotimiDesire
Copy link

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/

Describe changes:

  • This Pull request addresses several failing DCERPC tests.
  • I made changes to adjust "test_process_bind_pdu" and "test_process_header" to use a valid 16-byte header sequence. Also, I got rid of unused zeros in the protocol patterns.
  • Currently, 516 tests passed, but I have been unable to figure out the last three. They include: ("test_bind_acks_alter_contexts_internal_ids", "test_parse_bind_pdu", "test_parse_bind_pdu_ctx_id_non_zero")

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 11, 2025
Copy link

NOTE: This PR may contain new authors.

@victorjulien
Copy link
Member

Can you update the commit to explain what is wrong with the tests? Right now the commits suggests "failures" are fixed, but it introduces many test failures.

Also please carefully review the PR template and fill it in.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but I am not sure I see the point.

This Pull request addresses several failing DCERPC tests.

The tests are not failing.
Do you mean they test a wrong behavior ?

Also, I got rid of unused zeros in the protocol patterns.

What do you mean ?
I am afraid you are referring to https://redmine.openinfosecfoundation.org/issues/6583
But https://redmine.openinfosecfoundation.org/issues/6583 is about b"|05 00|\0".as_ptr() as *const std::os::raw::c_char, 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outreachy Contributions made by Outreachy applicants

Development

Successfully merging this pull request may close these issues.

4 participants