pop3: AUTH command handling improvements #14035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better track the state so it's known when to expect a base64 request message. Also better validate the base64. Ticket: OISF#7994.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14035 +/- ##
==========================================
- Coverage 84.43% 84.42% -0.02%
==========================================
Files 1011 1011
Lines 272251 272285 +34
==========================================
- Hits 229876 229866 -10
- Misses 42375 42419 +44
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 27991 |
Could you not craft one ? (with ./libhtp/htptopcap.py or similar) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better track the state so it's known when to expect a base64 request message. Also better validate the base64.
Ticket: #7994.
No SV as the only PCAP I have is very private and also requires the sslproxy work.