Skip to content

Conversation

samfajobi
Copy link
Contributor

Ticket: #6315

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6315

Describe changes:
-Converts unittests to FAIL/PASS APIs in ippair-storage.c file

Provide values to any of the below to override the defaults.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

Signed-off-by
Olusegun Fajobi. [email protected]

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, looking good so far, just wait for CI

CI : waiting...
Code : good
Commits segmentation : ok
Commit messages : nit : needs one empty line between title and ticket number
Git ID set : looks fine for me
CLA : did you sign it ?
Doc update : not needed
Redmine ticket : ok
Rustfmt : no rust
Tests : ok
Dependencies added: none

Copy link

NOTE: This PR may contain new authors.

@victorjulien victorjulien added the outreachy Contributions made by Outreachy applicants label Oct 16, 2025
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (93c0409) to head (85e5241).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14047      +/-   ##
==========================================
+ Coverage   84.43%   84.45%   +0.02%     
==========================================
  Files        1011     1011              
  Lines      272251   272204      -47     
==========================================
+ Hits       229876   229898      +22     
+ Misses      42375    42306      -69     
Flag Coverage Δ
fuzzcorpus 63.41% <ø> (+<0.01%) ⬆️
livemode 19.34% <ø> (-0.01%) ⬇️
pcap 44.80% <ø> (-0.02%) ⬇️
suricata-verify 65.18% <ø> (-0.01%) ⬇️
unittests 59.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samfajobi
Copy link
Contributor Author

Thanks for the work, looking good so far, just wait for CI

CI : waiting... Code : good Commits segmentation : ok Commit messages : nit : needs one empty line between title and ticket number Git ID set : looks fine for me CLA : did you sign it ? Doc update : not needed Redmine ticket : ok Rustfmt : no rust Tests : ok Dependencies added: none

This CI is done and successful as well.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one will also need another round, for the commit message to adhere to our guidelines, as indicated in similar PRs ;)

@samfajobi
Copy link
Contributor Author

Closing this ticket in favour of #14066, which continues this work.

@samfajobi samfajobi closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outreachy Contributions made by Outreachy applicants

Development

Successfully merging this pull request may close these issues.

4 participants