Skip to content

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7929

Describe changes:

  • detect/vlan: move vlan.id code to generic integer
  • detect/integers: rename all1 to all and all to all_or_absent

#14053 needed rebase that compiles

SV_BRANCH=OISF/suricata-verify#2697

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 78.41727% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (2f633be) to head (17b6f4d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14064   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files        1011     1011           
  Lines      272282   272330   +48     
=======================================
+ Hits       229923   229964   +41     
- Misses      42359    42366    +7     
Flag Coverage Δ
fuzzcorpus 63.40% <63.82%> (+<0.01%) ⬆️
livemode 19.36% <0.00%> (+<0.01%) ⬆️
pcap 44.77% <0.00%> (-0.02%) ⬇️
suricata-verify 65.20% <64.13%> (-0.01%) ⬇️
unittests 59.45% <47.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jasonish
Copy link
Member

Do we need a note in the upgrade guide?

@catenacyber
Copy link
Contributor Author

The all does not exist in 8

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks good to me, thanks :)

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 654 631 96.48%

Pipeline = 28010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants