Skip to content

Conversation

Promisecharles
Copy link

Bug: #5711

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

changed the print format from the fprintf(stderr) to SCLog as directed in #14034

Link to ticket: https://redmine.openinfosecfoundation.org/issues/5711

Describe changes:

  • Add hint about missing runmode

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

Signed-off-by
Charles P. [email protected]

@Promisecharles Promisecharles force-pushed the add-hint-about-missing-runmode branch from 7b9b450 to e6673e9 Compare October 18, 2025 00:06
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 18, 2025
Copy link

NOTE: This PR may contain new authors.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments. :)

We also still need only the changes pertaining to ticket #5711 to be a part of the commit and corresponding PR.

switch (suri->run_mode) {
case RUNMODE_UNKNOWN:

SCLogMessage(SC_LOG_WARNING, NULL, 0, NULL, "runmodes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use SCLogMessage directly. It is used by other functions from the SCLog API that have a more appropriate logging level, depending on the usecase. Here, SCLogWarning or even SCLogErrorwould work better.

Comment on lines +2460 to +2462



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add these extra lines. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outreachy Contributions made by Outreachy applicants

Development

Successfully merging this pull request may close these issues.

2 participants