Skip to content

Conversation

jasonish
Copy link
Member

The "backport" of #13927.
Ticket: https://redmine.openinfosecfoundation.org/issues/7902

SV_BRANCH=OISF/suricata-verify#2699

A simpler fix which just loses the fields with duplicate attribute names:

  • Prevents a crafted message from spamming the logs

Also add the idea of a known issues page to the documentation.

Changes from last PR:

  • forgot about distcheck

Track what attributes have been logged and skip over duplicate
attributes to avoid having duplicate fields in the JSON object, which
is invalid JSON.

This is lossy, subsequent attributes are lost.

Ticket: OISF#7923
The idea of this page is to track known issues on a release branch
that we do not plan to fix.
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.88%. Comparing base (77057e1) to head (a4f722f).

Additional details and impacted files
@@             Coverage Diff             @@
##           main-8.0.x   #14074   +/-   ##
===========================================
  Coverage       83.88%   83.88%           
===========================================
  Files            1011     1011           
  Lines          275255   275261    +6     
===========================================
+ Hits           230904   230916   +12     
+ Misses          44351    44345    -6     
Flag Coverage Δ
fuzzcorpus 63.43% <100.00%> (+<0.01%) ⬆️
livemode 19.34% <0.00%> (-0.12%) ⬇️
pcap 44.74% <100.00%> (+0.01%) ⬆️
suricata-verify 65.19% <100.00%> (-0.01%) ⬇️
unittests 59.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victorjulien victorjulien added this to the 8.0 milestone Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants