detect: convert unittest in 'detect-filestore.c' to new FAIL/PASS API #14076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jhonny-rs wants to merge 1 commit into OISF:main from jhonny-rs:convert/detect-filestore.c

+4 −7

jhonny-rs commented Oct 19, 2025 •

edited

Loading

Ticket: #6317

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

I have read the contributing guide lines at
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html

Our Contribution agreements:

I have signed the Open Information Security Foundation contribution agreement at
https://suricata.io/about/contribution-agreement/ (note: this is only required once)

Changes (if applicable):

I have created a ticket at
https://redmine.openinfosecfoundation.org/projects/suricata/issues

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6317

Describe changes:

Modifies the PASS implementation to comply with the new FAIL/PASS API.
Declare variables on unittest on their first use.
Replace usage of SigInit with DetectEngineAppendSig.


          detect: convert unittest in 'detect-filestore.c' to new FAIL/PASS API

59c1156

Ticket: OISF#6317

jhonny-rs requested a review from victorjulien as a code owner

October 19, 2025 01:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet