-
Notifications
You must be signed in to change notification settings - Fork 1.6k
detect/analyzer: add more details for the xbits keyword. #14252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
NOTE: This PR may contain new authors. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14252 +/- ##
==========================================
- Coverage 84.14% 84.13% -0.02%
==========================================
Files 1013 1013
Lines 262313 262350 +37
==========================================
- Hits 220733 220732 -1
- Misses 41580 41618 +38
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hello, thanks for this contribution. Could you please create SV tests to go with this patch? You can check OISF/suricata-verify#2717 for an overall idea of what type of test we are looking for, for these engine analysis tasks :) |
jufajardini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something happened with the commit message: the ticket number is aaaaaalll the way lost to the right :P
This looks good, but will be easier to judge once we have the SV test, so I'm marking it as changes requested, for the SV tests, and the commit message.
the PR is here as requested github.com/OISF/suricata-verify/pull/2741 |
Add xbits keyword details to engine analysis output in DumpMatches function. Exposes cmd, name, track, and expire properties in JSON format, following the same pattern as byte_jump and flowbits. This improves the engine analysis report by providing complete information about xbits usage in rules when running with --engine-analysis flag. Task OISF#6351
c20cb6a to
09828ba
Compare
|
Task #6351
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6351
Describe changes:
Add xbits keyword details to engine analysis output in DumpMatches function. Exposes cmd, name, track, and expire properties in JSON format, following the same pattern as byte_jump and flowbits.
This improves the engine analysis report by providing complete information about xbits usage in rules when running with --engine-analysis flag.
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=github.com/OISF/suricata-verify/pull/2741
SU_REPO=
SU_BRANCH=
James Kaddu: [email protected]