Skip to content

Tcp big 6977 v1 #14321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+92 −2
Draft

Tcp big 6977 v1 #14321

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
387a6c8
stream/tcp: limit data length processed in one single packet
catenacyber Nov 12, 2025
9d54483
stream/tcp: configurable limit for max data processed per packet
catenacyber Nov 12, 2025
551ae16
stream/tcp: create eof pseudo-packets until we consume all data
catenacyber Nov 12, 2025
b8b4427
fixup! stream/tcp: configurable limit for max data processed per packet
catenacyber Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/stream-tcp-reassemble.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,9 @@ static bool GetAppBuffer(const TcpStream *stream, const uint8_t **data, uint32_t
*data_len = 0;
}
}
if (*data_len > UINT16_MAX) {
Copy link
Contributor Author

@catenacyber catenacyber Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the core of the solution !

Copy link
Member

@inashivb inashivb Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not there in the PR now. Is that on purpose?

Copy link
Contributor Author

@catenacyber catenacyber Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is still there, but the condition changed to be configurable

*data_len = UINT16_MAX;
}
return gap_ahead;
}

Expand Down