schema: document and clean-up - v6 #14335
Closed
+286
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were removed with a5587fe but these mentions went under the radar.
The schema accounts for a stats counters group that is a subgroup of the flows stats counters. Remove `flow_mgr`, thus.
While the counters exist, they're not present in the schema, causing validation to fail if stats.stream-events is enabled. Task OISF#7858
Part of the schema documentation effort. Related to Task OISF#6434
The `stats.capture` object may have different properties based on the capture method used. This adds the ones pertaining to AF_PACKET capture. Related to Task OISF#6434
For FTP, Host, IP Pair and HTTP. Related to Task OISF#6434
|
Information: QA skipped due to no C or rust code changed detected. Set to force a run. Pipeline = code |
victorjulien
approved these changes
Nov 15, 2025
Closed
victorjulien
requested changes
Nov 15, 2025
Member
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
This failed in staging. @jasonish we should probably make sure these checks run for just schema updating PRs as well.
Member
Will add to the doc job. |
Contributor
Author
Argh. |
Contributor
Author
|
ordering fixed with #14338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #14334
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7858
https://redmine.openinfosecfoundation.org/issues/7434
Describe changes:
capture.errorsgeneric, instead of AF_PACKET onlycapture.afpacketwithin its ownpropertiesSV_BRANCH=OISF/suricata-verify#2761