feat: add tags to map filters #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
force-pushed
the
feat/map/finish-filtering
branch
4 times, most recently
from
b539f0f
to
6028cb2
Compare
mariojsnunes
reviewed
Nov 7, 2024
benfurber
force-pushed
the
feat/map/finish-filtering
branch
from
6028cb2
to
0c3066b
Compare
|
will this show 'all activities tags' because at this point we would mainly need the ones from the spaces, the ones from individual members could be added later.. |
|
@davehakkens It filters out unused tags. I.e. it only shows the filters for the pins that exist. So until a tag is used, it won't be on the list. |
benfurber
force-pushed
the
feat/map/finish-filtering
branch
from
0c3066b
to
f58266d
Compare
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3991
|
| Run status |
|
| Run duration | 05m 30s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
74
|
| View all changes introduced in this branch ↗︎ | |
benfurber
force-pushed
the
feat/map/finish-filtering
branch
2 times, most recently
from
8c22fa4
to
a3f85ee
Compare
benfurber
force-pushed
the
feat/map/finish-filtering
branch
from
a3f85ee
to
2c37515
Compare
benfurber
force-pushed
the
feat/map/finish-filtering
branch
from
2c37515
to
6f577aa
Compare
mariojsnunes
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
So far...
Screen.Recording.2024-11-07.at.16.01.24.mov