Update Fuse.js configuration to adjust search threshold

[precious-onyenaucheya-ons]

What is the context of this PR?

This PR fixes #3347

This PR updates the Fuse.js configuration to address an issue where only the first 30 characters in the list seem to be searched.

The previous threshold setting of 0.2 was too restrictive, causing the search to miss relevant entries when queries became longer. With this update, users can now set the search threshold between 0 and 1, allowing for greater flexibility and improving search accuracy across different query lengths.

How to review this PR

Describe the steps required to test the changes (include screenshots if appropriate).

1. Run the search functionality with the updated configuration.
2. Perform a search for "South Georgia and the South Sandwich Islands" with the updated threshold.
3. Verify that the search result appears when searching for "South Sa" and similar queries.

Checklist

This needs to be completed by the person raising the PR.

• I have selected the correct Assignee
• I have linked the correct Issue

[netlify]

✅ Deploy Preview for ons-design-system-preview ready!

Name	Link
🔨 Latest commit	c29b7c2
🔍 Latest deploy log	https://app.netlify.com/sites/ons-design-system-preview/deploys/672b467bca8de300081e8152
😎 Deploy Preview	https://deploy-preview-3288--ons-design-system-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rmccar]

The description now needs updating with the latest changes

[rmccar]

I think there may be an issue with this not working as expected, I upped the threshold to 0.8 in the example and was still getting the same results. So you may need to make sure that is being passed into the config correctly

Noticed something that needs to be fixed

[admilne]

@precious-onyenaucheya-ons @rmccar

Sorry, I ran out of time to look at this on Friday after running into some git permission issues Precious is aware of but I wanted to take a look before you have stand up in the morning. I'm not sure if I've misunderstood the ticket and the requirements - it wasn't entirely clear for me but this doesn't look like it's working to me. Could be I'm not looking at it correctly but once I hit around 32 characters in the search box it no longer returns the results I'd expect. I've taken some screen shots to illustrate what I experienced.

• "South Georgia and the South San" - returns what i'd expect
• "South Georgia and the South Sand" - doesn't seem to return anything
• "South Georgia and the South Sandw" - gives me some results, but doesn't seem to be based on anything I've searched for
• "South Georgia and the South Sandwich Island" - still appears to give me results not based on my search
• "South Georgia and the South Sandwich Islands" - suddenly seems to kick back in to life and return an expected result but along with unexpected results too.

I tried playing with the thresholds but this didn't seem to make any difference to the issues I've described above.

[adi-unni]

I'd also like to second @admilne's findings. I've also done some additional testing with some of my own examples.
I created a new JSON file with only examples of search terms which are longer than 32 characters. It seems like the search threshold doesn't change the results when typing. Whats more worrysome is the fact that words outside of the 32 character soft limit aren't picked up by fuse.

In this picture, you can see this is a search term. You can also see the word characters in the search terms which is the 54th character in the field

Characters does not return anything in this scenario

This might seem like an edge case but say there was a scenario where a user wanted to match this:

Ultra HD 4K Smart Television Model XYZ1234567890

based on the model number which is outside of 32 characters

You can test my changes in: feature/3282/increase-search-threshold-adi

Edit: Actually in even more testing, back to the original example (testing in countries-multiple), if you type "sandwich islands", you'd expect "South Georgia and the South Sandwich Islands" to appear but nothing appears

Edit 2: Even weirder, if you search for "thi" in the search box in my example, you get matches for "thi" beyond 32 characters? Not sure if this is because its previously matched "thi" at the beginning.

Needs rereview

[rmccar]

I'd also like to second @admilne's findings. I've also done some additional testing with some of my own examples. I created a new JSON file with only examples of search terms which are longer than 32 characters. It seems like the search threshold doesn't change the results when typing. Whats more worrysome is the fact that words outside of the 32 character soft limit aren't picked up by fuse.

In this picture, you can see `this` is a search term. You can also see the word `characters` in the search terms which is the 54th character in the field Characters does not return anything in this scenario

This might seem like an edge case but say there was a scenario where a user wanted to match this:

Ultra HD 4K Smart Television Model XYZ1234567890

based on the model number which is outside of 32 characters

You can test my changes in: feature/3282/increase-search-threshold-adi

Edit: Actually in even more testing, back to the original example (testing in countries-multiple), if you type "sandwich islands", you'd expect "South Georgia and the South Sandwich Islands" to appear but nothing appears

Edit 2: Even weirder, if you search for "thi" in the search box in my example, you get matches for "thi" beyond 32 characters? Not sure if this is because its previously matched "thi" at the beginning.

These issues seem to be fixed by changing the distance to 500 in my testing without changing the threshold at all. So maybe we need to parameterise the distance not the threshold. But the issues Andrew highlighted still seem to be an issue. There might be an issue with the length of the query string entered which would cause the issues Andrew has found. This all needs bit more testing to make sure we get a balance between the distance and threshold. Testing with ignoreLocation might also be something we want to look into.

[rmccar]

Ive found an issue with the component search on the DS. It finds the list of components when you start typing the name of a component but no longer goes to that page when you click the suggestion. There is this error in the console:

But the issues Andrew found do seem to be fixed now

[admilne]

LGTM and looks like it's working as expected