-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Address input component test file to new format #3316
Refactor Address input component test file to new format #3316
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think part of the work on this was to move the examples like EXAMPLE_MANUAL_INPUT_FIELDS out into its own file and then be imported. Have a look at one of the ones Bali has done |
a2e0924
to
496bd95
Compare
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor things
What is the context of this PR?
Fixes: ONSdigital/design-team#132
This PR involves refactoring of the address input test document to follow the Given, When, Then testing approach.
How to review this PR
Functionality:
Does this testing refactor meet the following success criteria:
Look at the refactored code in relation to:
Checklist
This needs to be completed by the person raising the PR.