-
Notifications
You must be signed in to change notification settings - Fork 15
Upgrade WebdriverIO to v9.20.0 #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yuyutsu Rai <[email protected]>
… for more robust testing
…tly used in webdriverv8 Signed-off-by: Yuyutsu Rai <[email protected]>
Signed-off-by: Yuyutsu Rai <[email protected]>
…on and interestital spec
…plemenetary data tests are executing before page is rendered Signed-off-by: Yuyutsu Rai <[email protected]>
berroar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just wondering with:
Some tests became flaky due to reliance onbrowser.pause() to avoid race conditions. Therefore a new helper function has been added, waitForPageToLoad(), which waits for the page to fully load.
Did we test without replacing these at all? I think they were initially added before we went back to running consecutively?
Tested on a seperate branch and works without browser.pause. Changes have now been added to this branch 👍 |
berroar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observing a lot of The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D` in the run logs.
Transitive package from: I have upgraded the dependencies in babel so now |
What is the context of this PR?
This PR upgrades all WDIO packages to
v9.20.0and updates our functional tests to comply with the new upgrades.Changes made
getHTML()no longer takes a boolean flag. It now accepts an options object. The default options:({ includeSelectorTag: true, prettify: true })were causing differences in the returned HTML, which led to assertion failures (formatting changes and missing alt attributes on logo tags). We have to explicitly set these values to false.newWindow()now needs to explicitly have a URL value. In v8,newWindow()implicitly openedabout:blankwhen no URL was provided. In v9 this implicit default was removed, so we now explicitly pass 'about:blank' when opening a new window.SDS Tests in GA are failing when in the main test, but work when separated into their own job with "MAX_INSTANCE=1". Also the very first SDS launch always hits the “Sorry, there is a problem with this service” page. So a new helper function -
openQuestionnaireWithRetry(). I think we need an investigation on why SDS is failing like this in GA only.Chrome options also updated in an attempt to make tests more consistent.
Babel dependencies have also been upgraded to latest versions
How to review
Links
Checklist