Skip to content

Conversation

@Yuyuutsu
Copy link
Contributor

@Yuyuutsu Yuyuutsu commented Nov 3, 2025

What is the context of this PR?

This PR upgrades all WDIO packages to v9.20.0 and updates our functional tests to comply with the new upgrades.

Changes made

  • getHTML() no longer takes a boolean flag. It now accepts an options object. The default options:
    ({ includeSelectorTag: true, prettify: true }) were causing differences in the returned HTML, which led to assertion failures (formatting changes and missing alt attributes on logo tags). We have to explicitly set these values to false.

  • newWindow() now needs to explicitly have a URL value. In v8, newWindow() implicitly opened about:blank when no URL was provided. In v9 this implicit default was removed, so we now explicitly pass 'about:blank' when opening a new window.

  • SDS Tests in GA are failing when in the main test, but work when separated into their own job with "MAX_INSTANCE=1". Also the very first SDS launch always hits the “Sorry, there is a problem with this service” page. So a new helper function - openQuestionnaireWithRetry(). I think we need an investigation on why SDS is failing like this in GA only.

  • Chrome options also updated in an attempt to make tests more consistent.

  • Babel dependencies have also been upgraded to latest versions

How to review

  • Run Functional tests locally and see if they all work as expected
  • Check all test-functional commands work as expected
  • Do you agree with the changes made? There are multiple routes we can take with these changes, happy to hear out any suggestions.

Links

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@Yuyuutsu Yuyuutsu changed the title upgrade webdriver Upgrade Webdriver to v9.20.0 Nov 3, 2025
@Yuyuutsu Yuyuutsu marked this pull request as ready for review November 5, 2025 10:57
@Yuyuutsu Yuyuutsu requested a review from a team as a code owner November 5, 2025 10:57
@Yuyuutsu Yuyuutsu changed the title Upgrade Webdriver to v9.20.0 Upgrade WebdriverIO to v9.20.0 Nov 5, 2025
Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just wondering with:
Some tests became flaky due to reliance onbrowser.pause() to avoid race conditions. Therefore a new helper function has been added, waitForPageToLoad(), which waits for the page to fully load.
Did we test without replacing these at all? I think they were initially added before we went back to running consecutively?

@Yuyuutsu
Copy link
Contributor Author

Was just wondering with: Some tests became flaky due to reliance onbrowser.pause() to avoid race conditions. Therefore a new helper function has been added, waitForPageToLoad(), which waits for the page to fully load. Did we test without replacing these at all? I think they were initially added before we went back to running consecutively?

Tested on a seperate branch and works without browser.pause. Changes have now been added to this branch 👍

Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observing a lot of The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D` in the run logs.

@Yuyuutsu
Copy link
Contributor Author

Yuyuutsu commented Nov 28, 2025

Observing a lot of The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D` in the run logs.

Transitive package from:

I have upgraded the dependencies in babel so now baseline-brwoser-mapping is on the latest version.
Other devs are having the same issue with this warning message:
web-platform-dx/baseline-browser-mapping#107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants