Skip to content

Update redis to v7.1.0, cachetools to v6.2.2.0 and gevent to v25.9.1 #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rmccar wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update redis to v7.1.0, cachetools to v6.2.2.0 and gevent to v25.9.1 #1786

rmccar wants to merge 9 commits into from

Conversation

@rmccar
Copy link
Contributor

@rmccar rmccar commented Dec 3, 2025 •
edited
Loading

What is the context of this PR?

This PR updates all the dependancies from this PR that aren't Marshmallow.

These are:

  • redis
  • cachetools
  • gevent

This is due to some linting errors being surfaced by the update of Marshmallow, I have taken the decision to split it out into another PR.

How to review

  • Tests pass
  • Runner spins up locally and loads schemas as expected

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@rmccar rmccar requested a review from a team as a code owner December 3, 2025 12:38
@rmccar rmccar added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Dec 3, 2025
@rmccar rmccar changed the title Updates the dependencies that aren't marshmallow Update dependencies that aren't marshmallow Dec 3, 2025
@rmccar rmccar changed the title Update dependencies that aren't marshmallow Update dependencies that aren't marshmallow from dependabot PR Dec 3, 2025
@rmccar rmccar mentioned this pull request Dec 3, 2025
Closed
@rmccar rmccar changed the title Update dependencies that aren't marshmallow from dependabot PR Update dependencies that aren't Marshmallow from dependabot PR Dec 3, 2025
@VirajP1002
Copy link
Contributor

VirajP1002 commented Dec 4, 2025 •
edited
Loading

Minor comment, I was just glancing at the PR but would it be worth having the dependencies you update in the title? Just since it might be misinterpreted 😅

@rmccar rmccar changed the title Update dependencies that aren't Marshmallow from dependabot PR Update redis, cachetools and gevent Dec 4, 2025
@rmccar
Copy link
Contributor Author

rmccar commented Dec 4, 2025

Minor comment, I was just glancing at the PR but would it be worth the title having the dependencies you update? Just since it might be misinterpreted 😅

Yeah good point, updated

berroar
berroar reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some performance testing, as there are a couple of significant bumps here 👍

@ons-eq-team
Copy link
Contributor

ons-eq-team commented Dec 11, 2025

Benchmark Results

Percentile Averages:
50th: 83ms
90th: 331ms
95th: 545ms
99th: 1047ms
99.9th: 1681ms
GETs (99th): 1265ms
POSTs (99th): 796ms

PDF: 12000ms
Session: 8000ms

Total Requests: 64,034
Total Failures: 0
Error Percentage: 0.0%

@rmccar rmccar changed the title Update redis, cachetools and gevent Update redis to v7.1.0, cachetools to v6.2.2.0 and gevent to v25.9.1 Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berroar berroar berroar left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rmccar @VirajP1002 @ons-eq-team @berroar