Add PublishingQueueCollectionDetails endpoint #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A clone of the existing collection details endpoint, but without populating any lists of files that are in the collection. This is due to the issue of having too many files listed in the publish queue screen, which prevents it from loading.
rav-pradhan
reviewed
Dec 16, 2020
There was a problem hiding this comment.
I was able to test locally and could see the endpoint returning the relevant data in Florence. Left a minor comment but that wouldn't block approval.
Not sure if the policy is different for legacy systems but should we still add a test suite to cover the use case?
| public CollectionDetail get(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException, ZebedeeException { | ||
|
|
||
| com.github.onsdigital.zebedee.model.Collection collection = Collections |
There was a problem hiding this comment.
Is there a reason we're not importing this like the statements at the top of the file?
There was a problem hiding this comment.
I think it has been done elsewhere due to name clashes, where the same class name is used in two different namespaces. I don't think it's required here though, so I will do the import 👍
- throw exceptions instead of directly setting API response codes as the framework handles this - required some changes to the class to enable testing
rav-pradhan
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A clone of the existing collection details endpoint, but without populating any lists of files that are in the collection. This is due to the issue of having too many files listed in the publish queue screen, which prevents it from loading.
Note: this PR removes all listing of files, including datasets. I thought it best to be consistent and either list all files or not.
How to review
Sanity check
Test that the publishing queue loads correctly if you have the publishing system running locally.
Who can review
Anyone