Refactor ZebedeeConfiguration for readbility #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janderson2
force-pushed
the
feature/refactor-startup-part-1
branch
from
01d4fec
to
cece436
Compare
daiLlew
reviewed
Feb 9, 2022
There was a problem hiding this comment.
I've reviewed the changes and they make sense to me. I've checkout the branch and run the unit tests and integration test suite we have. I've also run it in my local stack and created and published a collection & everything appears to be working correctly.
I've added 1 minor comment otherwise Im happy to approve.
zebedee-cms/src/main/java/com/github/onsdigital/zebedee/ZebedeeConfiguration.java
Outdated
Show resolved
Hide resolved
janderson2
force-pushed
the
feature/refactor-startup-part-1
branch
2 times, most recently
from
2b02f06
to
c473635
Compare
Structure ZebedeeConfiguration in such a way as to keep the initialisation of each service together and to ensure that dependencies between services are clear.
janderson2
force-pushed
the
feature/refactor-startup-part-1
branch
from
c473635
to
fb98b25
Compare
…refactor-startup-part-1
…refactor-startup-part-1
…refactor-startup-part-1
…refactor-startup-part-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Structure ZebedeeConfiguration in such a way as to keep the
initialisation of each service together and to ensure that dependencies
between services are clear.
This is the first in a series of PRs to attempt to organise the startup to be easier to follow.
How to review
Ensure the changes make sense.
Who can review
Anyone but me.