Better use of the framework's Config system #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Seems good, can see any obvious breaking changes. Can you think of any situations where yaml config might have been set that will break due to this? |
Contributor
|
I wonder if keys etc should be able to be placed also in an environment file? |
Contributor
Author
|
@camfindlay Have tried to maintain backwards compatibility so YAML won't need changing. Agree that keys should be environment configurable, I'll raise it as a seperate issue. |
Contributor
|
Always enjoy a conflict... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of the Config system for specifying keys and passphrase, as well as using a private static for $options.