Skip to content

Output and assigning well rates for opm-geochemistry module#6893

Open
svenn-t wants to merge 2 commits intoOPM:masterfrom
svenn-t:geochemistry
Open

Output and assigning well rates for opm-geochemistry module#6893
svenn-t wants to merge 2 commits intoOPM:masterfrom
svenn-t:geochemistry

Conversation

@svenn-t
Copy link
Contributor

@svenn-t svenn-t commented Mar 3, 2026

This PR introduces output and well rate assignment for the new OPM geochemistry module, opm-geochemistry. Additionally, a new geochemistry property is introduced for activating the geochemistry module.

Depends on OPM/opm-common#5036

Introduces a compile-time variable to enable geochemistry module.
Species well rates are assigened for standard and multisegmented wells.
@totto82 totto82 added the manual:new-feature This is a new feature and should be described in the manual label Mar 5, 2026
assignSpeciesConcentrations(const unsigned globalDofIdx,
const AssignFunction& concentration)
{
std::for_each(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use std::ranges::for_each

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

assignMineralConcentrations(const unsigned globalDofIdx,
const AssignFunction& concentration)
{
std::for_each(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


// Output species concentrations
std::for_each(
species.begin(), species.end(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}
);
// Output mineral concentrations
std::for_each(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

auto solutionVectors = std::array {
DataEntry{"PH", UnitSystem::measure::identity, pH_}
};
std::for_each(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


} // namespace Opm

#endif No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing eol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:new-feature This is a new feature and should be described in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants