-
Notifications
You must be signed in to change notification settings - Fork 5
Governor Documentation and Model #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It would be good to make some additional clarification and make sure equations match the signal flow diagram.
Comments addressed. Awaiting @abirchfield comments, especially in regards to clarifying units. |
Untested implementation in recent commit, aligned with documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, name of model should be TGOV1 or Governor_TGOV1. TurbineGov could apply to other future governors and we want each to be unique. |
Per developer guidelines class names should be upper camel case format, something like this: We could also use just |
GovernorTgov1 is ok. |
Description
Documentation for the phasor dynamics governor (TGOV1) that will be implemented following this PR.
Proposed changes
Restructured folder to allow for many gov. types and added documentation for TGOV1
Further comments
There are piece-wise differential equations in this system. I wrote a short proposal on how to implement this to cooperate with the general solver. Please let me know if a bump function is sufficient or if the general solver can handle piece-wise definition (not to my knowledge).
Also there was a small latex issue in GENROU that I included in this PR.
Checklist