Gen classical #94
Open
Gen classical #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abirchfield
reviewed
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the second-order classical generator model as a Phasor Dynamics family of components. This model has been used to simulate a 2-bus example and the results outputted to a .csv file. New CMake files have been added as needed, and existing ones have been updated to incorporate the new additions.
This closes #73
Proposed changes
I have added a test case that sets up the system with a consistent DAE solution through the initialize method of the classical generator model and checks that the residual is zero. Another test case has been added to verify that the residuals are correct for other states different from the initialization. Additionally, the CMake files have been updated, and I have built and verified that all configurations work correctly.
Checklist