Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PAINNStack #273

Merged
merged 23 commits into from
Oct 10, 2024
Merged

Adding PAINNStack #273

merged 23 commits into from
Oct 10, 2024

Conversation

RylieWeaver
Copy link
Collaborator

The following is an implementation of the 'Polarizable Atom Interaction Neural Network' (PAINN) model.

(ArXiV Link](https://arxiv.org/abs/2102.03150)).

This is an equivariant message-passing stack.

@RylieWeaver
Copy link
Collaborator Author

Do not approve this yet if it passes the tests. I'm currently commenting out large blocks to identify the cause of the error.

@RylieWeaver RylieWeaver self-assigned this Sep 12, 2024
@RylieWeaver
Copy link
Collaborator Author

@allaffa @jychoi-hpc @pzhanggit

Could one of you request to have the tests re-run here? I believe I've made a change to fix an error.

@pzhanggit
Copy link
Collaborator

@allaffa @jychoi-hpc @pzhanggit

Could one of you request to have the tests re-run here? I believe I've made a change to fix an error.

Just re-ran it. It seems there is some format issue

@RylieWeaver RylieWeaver requested review from allaffa, JustinBakerMath and pzhanggit and removed request for JustinBakerMath September 13, 2024 13:03
@RylieWeaver
Copy link
Collaborator Author

@pzhanggit @allaffa I believe its passed all checks now. Could you review?

@allaffa allaffa added the enhancement New feature or request label Oct 3, 2024
@allaffa
Copy link
Collaborator

allaffa commented Oct 8, 2024

@RylieWeaver
This PR has conflicts with the main branch and cannot be merged automatically.
Please solve the conflicts.

@RylieWeaver
Copy link
Collaborator Author

@allaffa

The merge conflicts are fixed. More will pop up when MACE or this one is merged, but that can be fixed quick.

@allaffa allaffa merged commit ab8891f into ORNL:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants