Track updated status for each vector in multivector (third attempt) #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implementation.- Hacked to restore previous behavior.- All tests pass, error messages printed where undesired behavior occurs.
9 tasks
shakedregev
approved these changes
Jun 16, 2025
kswirydo
reviewed
Jun 16, 2025
| @@ -33,33 +34,37 @@ namespace ReSolve { namespace vector { | |||
| int copyDataFrom(const real_type* data, memory::MemorySpace memspaceIn, memory::MemorySpace memspaceOut); | |||
| int copyDataFrom(Vector* v, memory::MemorySpace memspaceIn, memory::MemorySpace memspaceOut); | |||
| real_type* getData(memory::MemorySpace memspace); | |||
| real_type* getData(index_type i, memory::MemorySpace memspace); // get pointer to i-th vector in multivector | |||
| real_type* getData(index_type i, memory::MemorySpace memspace); | |||
There was a problem hiding this comment.
what was wrong with this comment :D
| @@ -234,7 +234,7 @@ namespace ReSolve { | |||
| using namespace constants; | |||
|
|
|||
| if (k < 200) { | |||
| hip::mass_inner_product_two_vectors(size, k, x->getData(memory::DEVICE) , x->getData(1, memory::DEVICE), V->getData(memory::DEVICE), res->getData(memory::DEVICE)); | |||
| hip::mass_inner_product_two_vectors(size, k, x->getData(0, memory::DEVICE) , x->getData(1, memory::DEVICE), V->getData(memory::DEVICE), res->getData(memory::DEVICE)); | |||
There was a problem hiding this comment.
Code formatting is totally wrong here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vectorclass object is a multivector that allows access to individual vectors separately. It is plausible to expect that individual vectors could be updated individually and some of them may have device, while others may have host memory space updated. However, current implementation of theVectorclass allows only for setting update flags for all vectors together, regardless of how they are accessed and updated. This is a bug, see #259.@superwhiskers
Proposed changes
This PR provides following:
syncDataoverload to sync only one vector in multivector object. ClosesVector::getDatafunction incorrectly syncs memory spaces. #259.setToZeroandsetToConstmethods. Closes Vector initialization functions do not set "updated" flags correctly #216.GramSchmidtclass where multi vector view was set to a wrong size.getVectorDatafunction.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
This PR supersede #278.