Skip to content

Update Spack and setup CI with asan and ubsan variants #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 27, 2025

Conversation

nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Jun 26, 2025

Description

CI support for sanitizers

Proposed changes

  • Updated Spack package with asan and ubsan variants. PR to upstream Spack
  • Updated Frontier dependencies accordingly
  • Updated Github Actions pipeline to build and test with the sanitizers
  • Created targets resolve_asan and resolve_ubsan that can be exported. This was needed to make the consumer test work, in addition to ensuring that the compilers match.

Checklist

  • All tests pass. Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • N/A There are unit tests for the new code.
  • N/A The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@nkoukpaizan nkoukpaizan self-assigned this Jun 26, 2025
@nkoukpaizan nkoukpaizan force-pushed the nicholson/update-spack branch from cb0fbe7 to 5b8f275 Compare June 26, 2025 22:58
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest merging #325 before merging this to develop branch. Otherwise, looks good.

@nkoukpaizan nkoukpaizan merged commit 029462a into develop Jun 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants