-
Notifications
You must be signed in to change notification settings - Fork 38
Add 2 grid files for nl_nsgi #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can try this: #134 (comment) For the generation of the data I recommend using a script, as explained in #134 (comment) |
nl_nsgi/nl_nsgi_README.txt
Outdated
*Format*: GeoTIFF converted from GTX | ||
*License*: [Creative Commons Attribution 4.0](https://creativecommons.org/licenses/by/4.0/) | ||
|
||
* nl_nsgi_rdcorr2018.tif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the filename I see added in this PR: nl_nsgi_nllat2018.tif
.
Maybe it would be useful to mention the full name of the target CRS: EPSG:9287
"LAT NL depth" (to see it is a depth one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Line 41 of the nl_nsgi/nl_nsgi_README.txt should be indeed nl_nsgi_nllat2018.tif
Generating the grid files is no problem for me, and I convert my .txt to .gtx with gdal_translate and convert that to .tif with the vertoffset_grid_to_gtiff.py script. However, I am not able to get regenerate_index_html.py to run at the moment. I tried several things (without really understanding what I'm doing), but I keep getting diverent kinds of error messages. I hope someone else can run it when accepting this PR. |
I've regenerated the index |
Thanks! |
@Jochem-L just to be sure, there should be a corresponding PR in PROJ to add the link |
@ag-pix4d, I thought this was fixed by @rouault on 25 March. However, testing with PROJ 9.6.2 and PROJ-data 1.22 indeed gives a warning PROJ can't find
|
…rids Those grids were added in PROJ-data 1.22 per OSGeo/PROJ-data#137 but the proj.db changes were missing
no, I meant I had regenerated the geojson and html indexes for this repository (PROJ-data), but not for the PROJ database itself. I've just submitted OSGeo/PROJ#4534 for that. Please double check |
Thanks! |
I wasn't able to run regenerate_index_html.py (step 7 of https://github.com/OSGeo/PROJ-data/blob/master/CONTRIBUTING.md).