Skip to content

Add 2 grid files for nl_nsgi #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 25, 2025
Merged

Add 2 grid files for nl_nsgi #137

merged 17 commits into from
Mar 25, 2025

Conversation

Jochem-L
Copy link
Contributor

I wasn't able to run regenerate_index_html.py (step 7 of https://github.com/OSGeo/PROJ-data/blob/master/CONTRIBUTING.md).

@jjimenezshaw
Copy link
Contributor

jjimenezshaw commented Mar 13, 2025

I wasn't able to run regenerate_index_html.py

You can try this: #134 (comment)

For the generation of the data I recommend using a script, as explained in #134 (comment)

@kbevers kbevers added this to the 1.22 milestone Mar 13, 2025
*Format*: GeoTIFF converted from GTX
*License*: [Creative Commons Attribution 4.0](https://creativecommons.org/licenses/by/4.0/)

* nl_nsgi_rdcorr2018.tif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the filename I see added in this PR: nl_nsgi_nllat2018.tif.
Maybe it would be useful to mention the full name of the target CRS: EPSG:9287 "LAT NL depth" (to see it is a depth one).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Line 41 of the nl_nsgi/nl_nsgi_README.txt should be indeed nl_nsgi_nllat2018.tif

@Jochem-L
Copy link
Contributor Author

Jochem-L commented Mar 25, 2025

I wasn't able to run regenerate_index_html.py

You can try this: #134 (comment)
For the generation of the data I recommend using a script, as explained in #134 (comment)

Generating the grid files is no problem for me, and I convert my .txt to .gtx with gdal_translate and convert that to .tif with the vertoffset_grid_to_gtiff.py script.

However, I am not able to get regenerate_index_html.py to run at the moment. I tried several things (without really understanding what I'm doing), but I keep getting diverent kinds of error messages. I hope someone else can run it when accepting this PR.

@rouault rouault merged commit 60fe6b0 into OSGeo:master Mar 25, 2025
1 of 2 checks passed
@rouault
Copy link
Member

rouault commented Mar 25, 2025

I've regenerated the index

@Jochem-L
Copy link
Contributor Author

I've regenerated the index

Thanks!

@ag-pix4d
Copy link

@Jochem-L just to be sure, there should be a corresponding PR in PROJ to add the link nl_nsgi_bongeo2004.tif <-> bongeo2004.gtx to grid_alternatives table (similar to OSGeo/PROJ#4457) so that PROJ can use this grid file, right?

@Jochem-L
Copy link
Contributor Author

Jochem-L commented Jul 1, 2025

@ag-pix4d, I thought this was fixed by @rouault on 25 March. However, testing with PROJ 9.6.2 and PROJ-data 1.22 indeed gives a warning PROJ can't find bongeo2004.gtx while it should look for nl_nsgi_bongeo2004.tif. So it looks like link is still missing, but I'm not sure how to fix this.

projinfo -s EPSG:10761 -t EPSG:10764 --hide-ballpark -o proj
Candidate operations found: 1
-------------------------------------
Operation No. 1:

unknown id, Bonaire 2004 to Bonaire height (1) + Inverse of Bonaire to Bonaire 2004 (1) + Bonaire Transverse Mercator, 0.3 m, Bonaire, Sint Eustatius and Saba (BES Islands or Caribbean Netherlands) - Bonaire - onshore., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=bongeo2004.gtx +multiplier=1
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +exact +x=-366.1939 +y=-115.0688 +z=-776.7039
        +rx=20.96308 +ry=16.462749 +rz=-14.276379 +s=-12.809
        +convention=coordinate_frame
  +step +inv +proj=cart +ellps=intl
  +step +proj=pop +v_3
  +step +proj=tmerc +lat_0=12.180658675 +lon_0=-68.2518022805556 +k=1
        +x_0=23209.56 +y_0=21423.99 +ellps=intl

Grid bongeo2004.gtx needed but not found on the system.

rouault added a commit to rouault/PROJ that referenced this pull request Jul 1, 2025
…rids

Those grids were added in PROJ-data 1.22 per OSGeo/PROJ-data#137
but the proj.db changes were missing
@rouault
Copy link
Member

rouault commented Jul 1, 2025

I thought this was fixed by @rouault on 25 March

no, I meant I had regenerated the geojson and html indexes for this repository (PROJ-data), but not for the PROJ database itself. I've just submitted OSGeo/PROJ#4534 for that. Please double check

@Jochem-L
Copy link
Contributor Author

Jochem-L commented Jul 1, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants