SWIG/c#: Update string marshaling code to use utf-8 native strings #12546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am travelling for the next two days but can have a look after that ... |
|
I am reviewing it now |
szekerest
requested changes
Jun 17, 2025
|
hello , will this pr meged into next release? |
I'll be trying to review the UTF8 issues reported for the C# bindings and apply the necessary changes in the next few days. |
Sorry I didn't have time to apply the suggested changes. Please bear with me for a day or two :) |
added 2 commits
July 8, 2025 12:06
Update C# SWIG typemap to marshal array of strings as an array of utf-8 strings, as RFC 5 suggests. This fixes generated c# bindings and makes .net code to work with the datasets containing non-ascii characters in the text data.
szekerest
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update C# SWIG typemap to marshal array of strings as an array of utf-8 strings, as RFC 5 suggests.
This fixes generated c# bindings and makes .net code to work with the datasets containing non-ascii characters in the text data.
What does this PR do?
Fix SWIG/.net typemaps to treat strings in string arrays as utf-8 strings. This makes the datasets containing non-ascii characters in the text data usable by the .NET applications.
The use of UTF-8 in character data is mandated by RFC 5 (https://gdal.org/en/stable/development/rfc/rfc5_unicode.html).
What are related issues/pull requests?
Tasklist