tests: mark additional WMS/WMTS test as network-dependent #13812
Conversation
autotest/gdrivers/wms.py
Outdated
|
|
||
|
|
||
| @pytest.mark.network | ||
| @pytest.mark.require_curl |
There was a problem hiding this comment.
require_curl is not needed here since pytestmark = pytest.mark.require_driver("WMS") at line 28 implies it (the WMS driver is only enabled if CURL is enabled)
That pull request would only be worth it if generalized to marking (temptively) all tests that perform an external network access (tests doing localhost networking shouldn't be tagged with it)
There was a problem hiding this comment.
Thanks for the clarification.
You’re right , require_curl is redundant here given require_driver("WMS"). I’ll drop it.
Regarding scope,I agree that the marker is only really useful if applied more broadly. I kept this PR minimal as a follow-up example, but I’m happy to extend it to other tests that clearly perform external (non-localhost) network access if that’s preferred.
There was a problem hiding this comment.
All non-fuzzing CI checks are now green.
The remaining CIFuzz failure appears unrelated to the changes in this PR, which only affect pytest markers and do not touch any fuzzed code paths.
Happy to re-run or adjust if you think it’s related.
There was a problem hiding this comment.
The remaining CIFuzz failure appears unrelated to the changes in this PR,
yes that is unrelated. you can ignore that and concentrate on adding more markers where relevant
There was a problem hiding this comment.
All relevant tests performing external (non-localhost) network access have now been tagged, and CI is green.
I’ll leave it at this unless you’d like me to extend the marker coverage further.
There was a problem hiding this comment.
There are tests in the following files that would also benefit from the marker:
- autotest/gdrivers/gdalhttp.py
- autotest/gcore/vsis3.py
- autotest/gcore/vsigs.py
- autotest/gcore/vsicurl.py
- autotest/gcore/vsicurl_streaming.py
- autotest/ogr/ogr_sqlite.py
- autotest/ogr/ogr_shape.py
- autotest/ogr/ogr_shape_sbn.py
- autotest/ogr/ogr_parquet.py
2 participants
This PR is a small follow-up to the introduction of pytest.mark.network.
It applies the marker to an additional test that clearly depends on external
network access, following the same conservative, case-by-case approach
discussed in #10886.