checks: Enable more pre-commit tools from the pre-commit-hooks repo #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
force-pushed
the
add-precommit-tools
branch
from
df92c0a to
ccf5227
Compare
wenzeslaus
reviewed
Oct 17, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
This looks generally good. I think the path of least confusion is to have it as close to the main repo as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more checks to pre-commit, from the already downloaded and required https://github.com/pre-commit/pre-commit-hooks.
I commented out two of them, as there were too many changes to include right away, and might need a separate discussion.
I tried all the available hooks of that repo and kept these ones.
I'd like a second opinion on this, and will be waiting a bit, as I pretty much finished bringing up to date the linters in the repo.