Skip to content

chore: Fix invalid https URL, missing slashes #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Aug 3, 2025

Searched with the following regex: https:[^\/] and http:[^\/]

However, it shouldn't fix the compilation failure on Windows for v.maxent.swd, where an invalid character is found in the markdown file at position 5808:

Details

mkdir -p /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/bin
mkdir -p /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/etc
mkdir -p /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/docs/html
mkdir -p /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/docs/man
mkdir -p /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/docs/man/man1
mkdir -p /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/scripts
/usr/bin/install -c v.maxent.swd.py /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/scripts/v.maxent.swd.py
if [ "/c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/scripts/v.maxent.swd.py" != "" ] ; then GISRC=/usr/src/grass85/dist.x86_64-w64-mingw32/demolocation/.grassrc85 GISBASE=C:/msys64/usr/src/grass85/dist.x86_64-w64-mingw32 PATH="/usr/src/grass85/dist.x86_64-w64-mingw32/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/scripts:$PATH" PYTHONPATH="C:/msys64/usr/src/grass85/dist.x86_64-w64-mingw32/etc/python;C:/msys64/usr/src/grass85/dist.x86_64-w64-mingw32/gui/wxpython;$PYTHONPATH" PATH="/c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/scripts:/usr/src/grass85/dist.x86_64-w64-mingw32/lib:/usr/src/grass85/dist.x86_64-w64-mingw32/lib:/C/OSGeo4W/apps/qt5/bin:/C/OSGeo4W/apps/Python312/Scripts:/C/OSGeo4W/bin:/C/Windows/system32:/C/Windows:/C/Windows/system32/WBem:/usr/bin:/mingw64/bin/:/c/Users/landamar/grass_packager/grass841/addons/mswindows/osgeo4w/lib:/c/Users/landamar/grass_packager/grass841/addons/mswindows/osgeo4w:/c/windows32/system32:/c/windows:/c/windows32/system32:/c/windows:/c/msys64/usr/bin:/c/msys64/mingw64/bin" LC_ALL=C LANG=C LANGUAGE=C /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/scripts/v.maxent.swd.py --html-description < /dev/null | grep -v '</body>\|</html>\|</div> <!-- end container -->' > v.maxent.swd.tmp.html ; fi
VERSION_NUMBER=8.5.0dev VERSION_DATE=2025 MODULE_TOPDIR=/c/msys64/usr/src/grass85 \
        python3 /usr/src/grass85/dist.x86_64-w64-mingw32/utils/mkhtml.py v.maxent.swd > /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/docs/html/v.maxent.swd.html
VERSION_NUMBER=8.5.0dev /usr/src/grass85/dist.x86_64-w64-mingw32/utils/g.html2man.py "/c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/docs/html/v.maxent.swd.html" "/c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/docs/man/man1/v.maxent.swd.1"
if [ "/c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/scripts/v.maxent.swd.py" != "" ] ; then GISRC=/usr/src/grass85/dist.x86_64-w64-mingw32/demolocation/.grassrc85 GISBASE=C:/msys64/usr/src/grass85/dist.x86_64-w64-mingw32 PATH="/usr/src/grass85/dist.x86_64-w64-mingw32/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/scripts:$PATH" PYTHONPATH="C:/msys64/usr/src/grass85/dist.x86_64-w64-mingw32/etc/python;C:/msys64/usr/src/grass85/dist.x86_64-w64-mingw32/gui/wxpython;$PYTHONPATH" PATH="/c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/bin:/usr/src/grass85/dist.x86_64-w64-mingw32/scripts:/usr/src/grass85/dist.x86_64-w64-mingw32/lib:/usr/src/grass85/dist.x86_64-w64-mingw32/lib:/C/OSGeo4W/apps/qt5/bin:/C/OSGeo4W/apps/Python312/Scripts:/C/OSGeo4W/bin:/C/Windows/system32:/C/Windows:/C/Windows/system32/WBem:/usr/bin:/mingw64/bin/:/c/Users/landamar/grass_packager/grass841/addons/mswindows/osgeo4w/lib:/c/Users/landamar/grass_packager/grass841/addons/mswindows/osgeo4w:/c/windows32/system32:/c/windows:/c/windows32/system32:/c/windows:/c/msys64/usr/bin:/c/msys64/mingw64/bin" LC_ALL=C LANG=C LANGUAGE=C /c/Users/landamar/grass_packager/grass85/addons/v.maxent.swd/scripts/v.maxent.swd.py --md-description < /dev/null > v.maxent.swd.tmp.md ; fi
VERSION_NUMBER=8.5.0dev VERSION_DATE=2025 MODULE_TOPDIR=/c/msys64/usr/src/grass85 \
        python3 /usr/src/grass85/dist.x86_64-w64-mingw32/utils/mkmarkdown.py v.maxent.swd > /usr/src/grass85/dist.x86_64-w64-mingw32/docs/mkdocs/source/v.maxent.swd.md
Traceback (most recent call last):
  File "C:\msys64\usr\src\grass85\dist.x86_64-w64-mingw32\utils\mkmarkdown.py", line 261, in <module>
    main()
  File "C:\msys64\usr\src\grass85\dist.x86_64-w64-mingw32\utils\mkmarkdown.py", line 232, in main
    tool_generated = read_file(tmp_file)
                     ^^^^^^^^^^^^^^^^^^^
  File "C:\msys64\usr\src\grass85\dist.x86_64-w64-mingw32\utils\mkdocs.py", line 35, in read_file
    return Path(name).read_text()
           ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\OSGeo4W\apps\Python312\Lib\pathlib.py", line 1028, in read_text
    return f.read()
           ^^^^^^^^
  File "<frozen codecs>", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf4 in position 5808: invalid continuation byte
make: *** [/c/msys64/usr/src/grass85/include/Make/Html.make:11: /usr/src/grass85/dist.x86_64-w64-mingw32/docs/mkdocs/source/v.maxent.swd.md] Error 1
rm v.maxent.swd.tmp.md v.maxent.swd.tmp.html

Searched with the following regex: `https:[^\/]` and `http:[^\/]`
@echoix echoix requested a review from ecodiv August 3, 2025 21:01
@echoix echoix merged commit e1d16ff into OSGeo:grass8 Aug 3, 2025
7 checks passed
@echoix echoix deleted the invalid-https-url branch August 3, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant