-
-
Notifications
You must be signed in to change notification settings - Fork 65
download: Updated to new download page layout #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Overall it looks great, thanks @cwhite911 ! Two comments: |
petrasovaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Markus, source code could make sense as a separate tab. It is now in the menu instead. I don't have strong opinion where from these 2 locations it should be, but the button in the linux tab should not be downloading source code.
The download button on the mac site should directly lead to the binary.
Co-authored-by: Martin Landa <[email protected]>
…tab for source code
I've added a new "Source Code" tab, but also left the navigation option for source code.
The download button now has a drop down which give the user install options. The data model in grass.json is getting a little crazy and could probably use a refactor to make it easier to update and maintain. |
I agree. |
…to undefined page
|
Thanks for the updates, @cwhite911! The overall simplification and reduced submenu depth is great and definitely heading in the right direction! That said, after going through the changes, I feel like some sections might now be too minimal, which could leave new users (especially those unfamiliar with OSGeo4W or the context) a bit lost. Take the case of windows for example. There's an additional options title with no information (maybe it got lost in the way), and the osgeo4w installer is in the drop menu. I feel it does deserve some explanation and a separate section. I'm thinking on a windows user first arriving to the page and having zero info about osgeo... that person is then clueless. Maybe we can do as QGIS and call it online installer (https://qgis.org/download/) and recover some minimal info from the previous windows download page: The “View Source” links could be misleading. "Source" here sounds like source code, but these are actually binaries or installation instructions. Maybe the link could just be integrated into the distro name itself, or we could add a line explaining where the binary comes from before the command? Just something to reduce possible confusion. I noticed the Support Us button is missing under the Linux, Docker, and Source Code tabs—shouldn't this be consistent across all platforms? Thanks again for all the work! |
|
@veroandreo thank you for the feedback! I will work implementing your suggestions for Windows.
I removed the download button form those sections and the Support Us button was removed by mistake. Nice catch I'll add to those sections. |
|
@veroandreo I've addressed your current suggestion. Please take another look when you get a chance. |
Co-authored-by: Anna Petrasova <[email protected]>
Co-authored-by: Anna Petrasova <[email protected]>
|
I think the mac is still unclear, it should look more like windows in the sense that macports is additional install option, not instruction how to install from binaries. |
Good idea I'll update the Mac section. What do you think about the Linux tab donate buttons next to each source button? I think it might be too much and we should just have the Support Us button on the top and the Contribute/donate section at the bottom of the page. |
Please keep finding issues! We need these pages to be as simple and straight forward as possible. |
|
Would an independent hot fix be possible for |
|
@neteler Sorry I wasn't able to make it to this before you. Thanks for the quick fix. |
TODOs
|
We decided that because these are not an executable not to include it as a download button. |










I've added the new download layout. However, I need help confirming we have all the content for each OS. @neteler @veroandreo @wenzeslaus @petrasovaa please take a look and let me know if anything is missing.
We can add missing items to
data/grass.jsonThe point of this new layout is to help users install the most current version as quickly as possible for their OS by providing less options.
Linux
macOS
Windows
Docker