Skip to content

Conversation

@KomatiBhavaniSankar
Copy link
Contributor

Hello @cwhite911, and maintainers,

First, I sincerely apologize for closing the previous PR without consulting you beforehand. That was an oversight on my part. Based on the review comments and suggestions, I have now carefully implemented the requested changes and raised this new PR. I hope this update is closer to the expected standard.

Regarding the “Latest News 2025” dropdown arrow behavior #575 :
I followed the suggested markup-based solution to avoid additional JavaScript. However, after testing, the toggle icon behavior still shows design error and I saw a limitation when relying purely on Bootstrap’s default behavior. From my investigation, this appears to be a Bootstrap constraint, and a minimal JavaScript solution would fully resolve the issue. I wanted to highlight this transparently in case using a small JS snippet is acceptable.
Output Screenshot based on Suggestion:
Screenshot 2025-12-19 143607

Important note about the hamburger menu (production issue)

I would also like to explicitly highlight that the hamburger menu is not working in the production site. While investigating this issue, I noticed that the codebase predominantly uses Bootstrap 4, but some components are already written using Bootstrap 5 conventions. This mix causes the hamburger menu to fail in production.

To prevent breaking existing behavior, I initially added the Bootstrap script in
themes/grass/layouts/partials/navigation.html rather than partially modifying markup.
To address this properly and transparently, I opened a separate issue and PR:

This PR focuses on resolving the production hamburger menu issue in a cleaner and more consistent way.

Based on the feedback from the earlier PR (#576), I have also:

  • Removed unchanged files from the PR
  • Removed redundant library imports
  • Improved markup indentation and consistency
  • Avoided unnecessary JavaScript where possible

Thank you very much for your detailed reviews and guidance. I appreciate your patience and am happy to revise further based on your feedback.

Best regards,
Komati Bhavani Sankar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant